On-demand is a very cool concept... but let's look at this from a practical perspective. I only run my WH for a couple of hours in a 24 hour period. Once, usually, in the morning, and for a while in the evening. It takes just a few minutes for the tank to heat. Others, like Popeye (above) just use the pilot light to heat the tank. Either way, it doesn't take much propane.
A Suburban 6 gal electric-spark start WH is $348 on Amazon. The Girard (that fits the same space) is $511. That's $163 difference for the Girard.
I don't really know how much propane an on-demand WH would save you in a year's time, but $163 will buy you FORTY gallons of propane at $4/gallon. Now, I don't full-time in my van, but I do spend a couple of months a year in it at various times. I just spent 34 days on the road in the van and stayed in it 29 of those nights... and used about 3 gallons of propane and that was using the WH, cooking, running the propane forced-air furnace almost nightly, and running the fridge on propane much of that time. I suspect that most of my propane was used running the furnace and fridge... but even with that kind of use, forty gallons of propane will last a loooong time.
Yes, on-demand is a very cool concept, but like diesel engines, at their current prices it'll take a long time to recover the cost. And for those of us who stay off the grid for a while, it's kind of comforting to know I've got an extra six gallons of water in my HW tank should I ever need it.
A direct-spark ignition Suburban WH is $348 from Amazon, free shipping:
https://www.amazon.com/Suburban-509...387&sr=1-83&keywords=suburban+rv+water+heater
an on-demand Girard is $511 from Amazon, free shipping:
https://www.amazon.com/Girard-Prod-...r=1-1-catcorr&keywords=girard+rv+water+heater